-
-
Notifications
You must be signed in to change notification settings - Fork 26k
ENH Adds feature names support to dataframe protocol #26464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ogrisel
merged 24 commits into
scikit-learn:main
from
thomasjpfan:feature_names_dataframe_protocol
Jun 21, 2023
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
b49d391
ENH Adds feature names support to dataframe protocol
thomasjpfan 130db8e
DOC Adds PR number
thomasjpfan 412084e
FIX Use list
thomasjpfan 0d7945e
CLN Only use columns for dataframe like objects
thomasjpfan 66cdb93
DOC Adds more information
thomasjpfan e36e052
Apply suggestions from code review
thomasjpfan 1bf440f
DOC Update docstring
thomasjpfan 42287e7
Merge remote-tracking branch 'upstream/main' into feature_names_dataf…
thomasjpfan 42e741e
TST Adds polars and pyarrow test
thomasjpfan 42d2412
ENH Adds _is_pandas_df
thomasjpfan b42c6fa
Merge remote-tracking branch 'upstream/main' into feature_names_dataf…
thomasjpfan 3f56022
REV Revert env changes
thomasjpfan adb1354
CI Use conda-forge to enable pyarrow and polars tests
thomasjpfan 73342a6
CLN Adjust comments
thomasjpfan 879e960
DOC Better docs
thomasjpfan acb8183
Merge remote-tracking branch 'upstream/main' into feature_names_dataf…
thomasjpfan f8118ed
DOC Move changelog to 1.4
thomasjpfan ef432a7
CLN Address comments
thomasjpfan c75ac23
WIP
thomasjpfan a25581f
Merge remote-tracking branch 'upstream/main' into feature_names_dataf…
thomasjpfan 8e524e9
STY Fix
thomasjpfan 5e9cb61
Add comment to _get_feature_names to explain pandas special casing
ogrisel bf858fc
Link to issue to track pyarrow / asarray bug
ogrisel 9b3f26e
Merge branch 'main' into feature_names_dataframe_protocol
ogrisel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
71 changes: 52 additions & 19 deletions
71
build_tools/azure/pylatest_conda_forge_mkl_linux-64_conda.lock
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,4 +23,6 @@ dependencies: | |
- ccache | ||
- pytorch=1.13 | ||
- pytorch-cpu | ||
- polars | ||
- pyarrow | ||
- array-api-compat |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.