Skip to content

CLN Remove encoding declarations: # -*- coding: utf-8 -*- #26467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2023

Conversation

DimitriPapadopoulos
Copy link
Contributor

Reference Issues/PRs

What does this implement/fix? Explain your changes.

As previously done in 86e5679.

See also #20813.

Any other comments?

@DimitriPapadopoulos DimitriPapadopoulos changed the title CLN Remove encoding declarations: # -*- coding: utf-8 -*- [MRG] Remove encoding declarations: # -*- coding: utf-8 -*- May 31, 2023
@DimitriPapadopoulos DimitriPapadopoulos changed the title [MRG] Remove encoding declarations: # -*- coding: utf-8 -*- CLN Remove encoding declarations: # -*- coding: utf-8 -*- May 31, 2023
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They don't seem to have been added back. The blame points to 11 years ago for some of them :)
We must have missed them in the previous PR :)

LGTM. Thanks @DimitriPapadopoulos

@jeremiedbb jeremiedbb merged commit 6ca4970 into scikit-learn:main May 31, 2023
@DimitriPapadopoulos DimitriPapadopoulos deleted the coding_utf-8 branch May 31, 2023 16:23
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants