Skip to content

MAINT Delete vendored file from SciPy #26469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented May 31, 2023

Reference Issues/PRs

See #14971.

What does this implement/fix? Explain your changes.

Now that scikit-learn depends on SciPy 1.5, remove the vendored lobpcg.py file from SciPy, as bugs have been fixed in SciPy 1.4.

Any other comments?

Initial PR by @glemaitre.

The initial change had been tagged as Enhancement and listed under Miscellaneous in the changelog:
https://github.com/scikit-learn/scikit-learn/blob/main/doc/whats_new/v0.22.rst#miscellaneous

I have used the same here, but can move this under module sklearn.manifold if you prefer that.

@DimitriPapadopoulos DimitriPapadopoulos changed the title MAINT Deleted vendored file from SciPy MAINT Delete vendored file from SciPy May 31, 2023
This file had been copied from SciPy, to work around a bug in SciPy 1.3,
fixed in SciPy 1.4. Now that scikit-lean depends on SciPy 1.5, we can
revert this patch.
@jeremiedbb
Copy link
Member

Thanks bur there's already a PR for that: #26442. Let me close this one as duplicate

@jeremiedbb jeremiedbb closed this May 31, 2023
@DimitriPapadopoulos DimitriPapadopoulos deleted the _lobpcg.py branch May 31, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants