MAINT Delete vendored file from SciPy #26469
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
See #14971.
What does this implement/fix? Explain your changes.
Now that scikit-learn depends on SciPy 1.5, remove the vendored
lobpcg.py
file from SciPy, as bugs have been fixed in SciPy 1.4.Any other comments?
Initial PR by @glemaitre.
The initial change had been tagged as
Enhancement
and listed underMiscellaneous
in the changelog:https://github.com/scikit-learn/scikit-learn/blob/main/doc/whats_new/v0.22.rst#miscellaneous
I have used the same here, but can move this under module
sklearn.manifold
if you prefer that.