Skip to content

CI Update to conda-lock 2.0.0 #26510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 7, 2023
Merged

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Jun 4, 2023

The allows to clean up a few things in build_tools/update_environments_and_lock_files.py and is an opportunity to clean up other things not really related to conda-lock 2.0.0.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we also remove remove_unnecessary_package_from_lock_file added in #26184?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed I removed it in my last commit!

Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's nice 👍

@adrinjalali adrinjalali merged commit fbe7e5e into scikit-learn:main Jun 7, 2023
@lesteve lesteve deleted the update-conda-lock branch June 7, 2023 17:24
manudarmi pushed a commit to primait/scikit-learn that referenced this pull request Jun 12, 2023
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants