-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
Fix PowerTransformer leaves constant feature unchanged #26566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lesteve
merged 10 commits into
scikit-learn:main
from
jeremiedbb:fix-power-transformer-constant-feature
Jun 14, 2023
Merged
Fix PowerTransformer leaves constant feature unchanged #26566
lesteve
merged 10 commits into
scikit-learn:main
from
jeremiedbb:fix-power-transformer-constant-feature
Jun 14, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the sake of searchability, here is the error raised on the scipy-dev error log for
|
ogrisel
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Merging, thanks a lot! |
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
…26566) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a feature is constant,
Powertransformer
withmethod="yeo-johnson"
sets an unmeaningful lambda which arbitrarily scales the feature. I think it should be left unchanged in that case, and lambda should be set to 1 because the yeo-johnson transformation with lambda=1 correponds to the identity transformation.This also fixes a couple of failing tests in the scipy-dev job because scipy now raises an error when the optimisation of lambda failed (scipy/scipy#17704), which is the case for constant features.
(Note: this is irrelevant for method="boxcox" because it does not support constant features from the start and scipy already used to raise an informative error message)
Partial fix for #26154.