FIX seed in test_ridge_sample_weight_consistency [all random seeds] #26589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_ridge_sample_weight_consistency
|
It seems to work as expected: |
lorentzenchr
approved these changes
Jun 16, 2023
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jun 29, 2023
jeremiedbb
pushed a commit
that referenced
this pull request
Jun 29, 2023
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a random failure in
test_ridge_sample_weight_consistencywhile ensuring that the saga solver is not too seed sensitive.The failure was first observed in the unrelated #26464.
Note that the data used in this test still uses a fixed
42seed. I tried to change it toglobal_random_seedbut that would make the test fail for other (deterministic) solvers such as lbfgs for some seed values so I decided to keep this PR focused on seeding SAG and SAGA.