MNT Linter Bot: add concurrency group and a link to the commit for th… #26638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linting PassedAll linting checks passed. Your pull request is in excellent shape! ☀️ |
|
What do you think about adding a small visual hint like a green check next to "Linting passed" or a red cross next to "Linting issues" ? |
|
@jeremiedbb done. |
thomasjpfan
reviewed
Jun 21, 2023
.github/workflows/lint.yml
Outdated
| @@ -6,6 +6,10 @@ name: linter | |||
| on: | |||
| - pull_request_target | |||
|
|
|||
| concurrency: | |||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} | |||
There was a problem hiding this comment.
When does this workflow fallback to github.ref?
|
@jeremiedbb @ogrisel this would fix the issues we see in PRs where they haven't merged with |
jeremiedbb
approved these changes
Jun 21, 2023
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jun 29, 2023
jeremiedbb
pushed a commit
that referenced
this pull request
Jun 29, 2023
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cancel running jobs and add a link to the commit for which the comment is generated, example: adrinjalali/gh-action-test#5
cc @ogrisel @thomasjpfan