MAINT solve the failure in scipy-dev #26646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

ogrisel merged 8 commits into scikit-learn:main from glemaitre:fix_scipy_dev_ci_2

Jun 21, 2023

Member

glemaitre commented Jun 21, 2023

Try to solve issue seen in the scipy-dev CI


          MAINT solve the failure in scipy-dev

d69de41

github-actions bot added the module:linear_model label


          [scipy-dev] trigger the scipy-dev

49dbd8c

github-actions bot commented Jun 21, 2023 •

edited

Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: b8f6667

glemaitre added the No Changelog Needed label

Member Author

glemaitre commented Jun 21, 2023

I assume that one of the failures is raised by the following change in NumPy:

ENH,API: Make the errstate/extobj a contextvar numpy/numpy#23936 -> we enter twice in np.errstate. It could be a joblib issue.
API: deprecate compat and selected lib utils numpy/numpy#23830 -> np.byte_bounds is deprecated. It should be solved in joblib.

ogrisel mentioned this pull request

byte_bounds is deprecated in numpy dev joblib/joblib#1454

Closed

glemaitre added 3 commits

June 21, 2023 13:58


          iter [scipy-dev]

ea0b8c3


          iter

fe0be81


          [scipy-dev] iter

66bfa2d

Member

ogrisel commented Jun 21, 2023

I reported the random numpy errstate regression upstream:

BUG: TypeError: Cannot enter np.errstate twice when creating np.random.RandomState instances concurrently numpy/numpy#24013


          iter

f65d808

thomasjpfan reviewed

View reviewed changes

sklearn/linear_model/tests/test_quantile.py Outdated Show resolved Hide resolved

glemaitre commented

View reviewed changes

sklearn/linear_model/tests/test_quantile.py Outdated Show resolved Hide resolved

glemaitre commented

View reviewed changes

sklearn/linear_model/tests/test_quantile.py Outdated Show resolved Hide resolved

glemaitre commented

View reviewed changes

sklearn/linear_model/tests/test_quantile.py Outdated Show resolved Hide resolved


          Apply suggestions from code review

74adffa

glemaitre commented

View reviewed changes

sklearn/linear_model/tests/test_quantile.py Outdated Show resolved Hide resolved

glemaitre commented

View reviewed changes

sklearn/linear_model/tests/test_quantile.py Outdated Show resolved Hide resolved

glemaitre commented

View reviewed changes

sklearn/linear_model/tests/test_quantile.py Outdated Show resolved Hide resolved


          Apply suggestions from code review

b8f6667

thomasjpfan approved these changes

View reviewed changes

Member

thomasjpfan left a comment

LGTM

ogrisel approved these changes

View reviewed changes

ogrisel merged commit 9ff86c6 into scikit-learn:main

jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request


          MAINT solve the failure in scipy-dev (scikit-learn#26646)

cb2adfb

jeremiedbb pushed a commit that referenced this pull request


          MAINT solve the failure in scipy-dev (#26646)

ab833e1

REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request


          MAINT solve the failure in scipy-dev (scikit-learn#26646)

f6119d8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:linear_model No Changelog Needed