Skip to content

FIX use None as default in HDBSCAN #26650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2023
Merged

FIX use None as default in HDBSCAN #26650

merged 1 commit into from
Jun 21, 2023

Conversation

glemaitre
Copy link
Member

I saw that we are using n_jobs=4 by default for HDBSCAN which is not the usual policy.
I also remove a list conversion that does seem necessay.

@thomasjpfan thomasjpfan added this to the 1.3 milestone Jun 21, 2023
@github-actions
Copy link

Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

thomasjpfan
thomasjpfan approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremiedbb jeremiedbb added the To backport PR merged in master that need a backport to a release branch defined based on the milestone. label Jun 21, 2023
@jeremiedbb jeremiedbb enabled auto-merge (squash) June 21, 2023 13:59
@jeremiedbb jeremiedbb merged commit 33a1f16 into scikit-learn:main Jun 21, 2023
Vincent-Maladiere pushed a commit to Vincent-Maladiere/scikit-learn that referenced this pull request Jun 22, 2023
@glemaitre @Vincent-Maladiere
FIX use None as default in HDBSCAN (scikit-learn#26650)
e04160c
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jun 29, 2023
@glemaitre @jeremiedbb
FIX use None as default in HDBSCAN (scikit-learn#26650)
90a3bc3
jeremiedbb pushed a commit that referenced this pull request Jun 29, 2023
@glemaitre @jeremiedbb
FIX use None as default in HDBSCAN (#26650)
b1485a1
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@glemaitre @REDVM
FIX use None as default in HDBSCAN (scikit-learn#26650)
5d41871
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
module:cluster To backport PR merged in master that need a backport to a release branch defined based on the milestone.
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@glemaitre @thomasjpfan @jeremiedbb