ENH Supports DataFrame API for polars in ColumnTransformer #26669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Linting PassedAll linting checks passed. Your pull request is in excellent shape! ☀️ Generated for commit: b2f2a23 |
adrinjalali
reviewed
Jun 22, 2023
| @@ -620,7 +620,7 @@ def _validate_output(self, result): | |||
| name for name, _, _, _ in self._iter(fitted=True, replace_strings=True) | |||
| ] | |||
| for Xs, name in zip(result, names): | |||
| if not getattr(Xs, "ndim", 0) == 2: | |||
| if not getattr(Xs, "ndim", 0) == 2 and not hasattr(Xs, "__dataframe__"): | |||
There was a problem hiding this comment.
can we PLEASE move these ducktypes to a utility?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #25896
Supersedes #26115
What does this implement/fix? Explain your changes.
As a first step, this PR adds polars support to
ColumnTransformerusing the DataFrame API Spec. TheColumnTransformerwill slice the DataFrame on the column axis and pass it as Polars DataFrames to the inner transformers.Any other comments?
This PR only adds polars input to
ColumnTransformer. Polars output is not in scope for this PR.