Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENH Adds polars output support to ColumnTransformer #26683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH Adds polars output support to ColumnTransformer #26683
Changes from all commits
2bee590
2f3146b
1115d2f
d606f15
9d73e39
485ada1
76a02c2
c3259c3
db65930
d494a20
96e3d92
02df48f
0e334a9
314f411
2b75d0f
623a73e
fd2976e
e6844ac
560225f
9e4c02b
e4e8249
f1a3669
deb7b67
9f8d58a
2c5a5b3
291d678
79feaa3
5718c30
838a2c8
23d91e0
12c5d66
a3e2efa
7b10847
693129e
12a06c7
1387223
9b263ef
f18f374
3fa90bb
3671d21
f848776
bc7628b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is setting
minversion
as a global fixure worth a thought?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand how
"pandas_not_installed"
is related to the body or the docstring of the test.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also checked the code for
_is_polars_df
and it does not seem to be related to whether pandas is installed or not at all.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, this test was to check that
_is_polars_df
is False "ducktyped polars dataframe". Specifically, objects that pass the initial check:scikit-learn/sklearn/utils/validation.py
Line 2031 in 87e6908
but not a polars dataframe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.