Skip to content

MAINT Remove soon-to-be deprecated scipy.sparse functions #26751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 12, 2023

Conversation

jjerphan
Copy link
Member

@jjerphan jjerphan commented Jul 2, 2023

Reference Issues/PRs

Towards #26418.

What does this implement/fix? Explain your changes.

With the deprecation of SciPy sparse matrices, those functions will also be removed.

Note that those changes extend the support of SciPy sparse matrices to SciPy sparse arrays.

Any other comments?

With the deprecation of SciPy sparse matrices, those
functions will also be removed.

Note that those changes extend the support of SciPy sparse
matrices to SciPy sparse arrays.

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@github-actions
Copy link

github-actions bot commented Jul 2, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 80377ba. Link to the linter CI: here

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan jjerphan marked this pull request as ready for review July 3, 2023 19:50
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! LGTM

@thomasjpfan thomasjpfan added the Waiting for Second Reviewer First reviewer is done, need a second one! label Jul 6, 2023
@jjerphan
Copy link
Member Author

jjerphan commented Jul 7, 2023

The reported decrease in coverage reported is due to the tests of sklearn.datasets not being run since they necessitate the network.

Is there a way to set SKLEARN_SKIP_NETWORK_TESTS=0 on the CI to run them?

Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@jeremiedbb jeremiedbb merged commit dfd299b into scikit-learn:main Jul 12, 2023
@jjerphan jjerphan deleted the maint/sparse-checks branch July 12, 2023 16:41
punndcoder28 pushed a commit to punndcoder28/scikit-learn that referenced this pull request Jul 29, 2023
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 18, 2023
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cython No Changelog Needed Waiting for Second Reviewer First reviewer is done, need a second one!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants