Skip to content

CLN v1.4.rst entries are not sorted #26759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

Charlie-XIAO
Copy link
Contributor

Reference Issues/PRs

xref #26748 (review)

What does this implement/fix? Explain your changes.

This PR sorts the modules in alphabetical order (according to the guide), and reorders the sections (according to v1.3.rst).

@Charlie-XIAO Charlie-XIAO changed the title CLN v1.4.rst entries are not sorted` CLN v1.4.rst entries are not sorted Jul 4, 2023
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: cb68527. Link to the linter CI: here

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

We normally update the sorting during release, but the sorting is rather bad right now. I am okay with merging this now.

@thomasjpfan thomasjpfan added the Waiting for Second Reviewer First reviewer is done, need a second one! label Jul 5, 2023
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Charlie-XIAO

@jeremiedbb jeremiedbb merged commit 3bdc03d into scikit-learn:main Jul 5, 2023
punndcoder28 pushed a commit to punndcoder28/scikit-learn that referenced this pull request Jul 29, 2023
@Charlie-XIAO Charlie-XIAO deleted the log-1-4-order branch September 23, 2023 13:46
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting for Second Reviewer First reviewer is done, need a second one!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants