Skip to content

Fix outdated function name _safe_indexing_column #26818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2023
Merged

Fix outdated function name _safe_indexing_column #26818

merged 1 commit into from
Jul 12, 2023

Conversation

romanlutz
Copy link
Contributor

Reference Issues/PRs

What does this implement/fix? Explain your changes.

_safe_indexing_column doesn't exist AFAICT. This PR renames it to _safe_indexing.

Any other comments?

@github-actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 5394880. Link to the linter CI: here

@adrinjalali
Copy link
Member

Thanks @romanlutz , since we're moving all of these out of __init__.py, I think it's best for it to be done as a part of #26686

cc @jeremiedbb

@romanlutz
Copy link
Contributor Author

Thanks @romanlutz , since we're moving all of these out of __init__.py, I think it's best for it to be done as a part of #26686

cc @jeremiedbb

Works for me! Feel free to close.

@jeremiedbb
Copy link
Member

I don't mind solving the conflicts. Let's merge this one. Thanks @romanlutz

jeremiedbb
jeremiedbb approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jeremiedbb jeremiedbb merged commit fa3ca7a into scikit-learn:main Jul 12, 2023
@romanlutz romanlutz deleted the romanlutz/fix_func_name branch July 12, 2023 11:22
punndcoder28 pushed a commit to punndcoder28/scikit-learn that referenced this pull request Jul 29, 2023
@romanlutz @punndcoder28
DOC fix outdated function name _safe_indexing_column (scikit-learn#26818
d86f5ed 
)
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 18, 2023
@romanlutz @glemaitre
DOC fix outdated function name _safe_indexing_column (scikit-learn#26818
87555fd 
)
jeremiedbb pushed a commit that referenced this pull request Sep 20, 2023
@romanlutz @jeremiedbb
DOC fix outdated function name _safe_indexing_column (#26818)
0044eb4
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@romanlutz @REDVM
DOC fix outdated function name _safe_indexing_column (scikit-learn#26818
b2dd9f7 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
module:utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@romanlutz @adrinjalali @jeremiedbb