✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

_{Generated for commit: 3efa8ca. Link to the linter CI: here}

I really think for our math functions this is too much of an overhead @jeremiedbb

I really think for our math functions this is too much of an overhead @jeremiedbb

Okay so it looks like it takes about ~100ns to validate if we do an early return with no further computation. For reference, computing safe_sqr for a one-element array runs around (after putting back in the check_array call) ~185ns. The overhead is much less impactful when applying the function for larger arrays.

I think this is an acceptable overhead for where this is used. Is there a particular use case where this results in a meaningful regression? I'm not sure about other math functions though.

To me it's not a matter of overhead which is very low even on math functions, but more about functions that are de facto public but should have been made private in the first place. @max-drexler here's a list of the remaining functions to add validation for #24862 (comment). We kind of agreed that we should not add validation for a bunch of function like this one.

Thanks for the feedback. I'll check out one of the remaining functions and open a new request.