Skip to content

DOC Remove reference to CharNGramAnalyzer #26846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Conversation

step21
Copy link
Contributor

@step21 step21 commented Jul 17, 2023

As CharNGramAnalyzer was removed in 2012, this commit replaces the reference to it in the tutorial with a reference to CountVectorizer set up to use character based n-grams.

Reference Issues/PRs

Fixes #26843

What does this implement/fix? Explain your changes.

It removes the reference to CharNGramAnalyzer, replacing it with CountVectorizer.

Any other comments?

As CharNGramAnalyzer was removed in 2012, this commit replaces the reference to it in the tutorial with a reference to CountVectorizer set up to use character based n-grams.
@github-actions
Copy link

github-actions bot commented Jul 17, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: db40d1b. Link to the linter CI: here

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @step21 !

Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
@thomasjpfan thomasjpfan changed the title Remove reference to CharNGramAnalyzer DOC Remove reference to CharNGramAnalyzer Jul 18, 2023
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan enabled auto-merge (squash) July 18, 2023 18:59
@thomasjpfan thomasjpfan merged commit 335b555 into scikit-learn:main Jul 18, 2023
punndcoder28 pushed a commit to punndcoder28/scikit-learn that referenced this pull request Jul 29, 2023
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 18, 2023
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
jeremiedbb pushed a commit that referenced this pull request Sep 20, 2023
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Where is CharNGramAnalyzer?
2 participants