Skip to content

DOC update description of support_vectors_ #26866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 21, 2023
Merged

Conversation

rprkh
Copy link
Contributor

@rprkh rprkh commented Jul 20, 2023

Reference Issues/PRs

Fixes #20068

What does this implement/fix? Explain your changes.

support_vectors_ would be an empty array with a precomputed kernel.

Any other comments?

@github-actions
Copy link

github-actions bot commented Jul 20, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: da43096. Link to the linter CI: here

@@ -774,7 +774,7 @@ class SVC(BaseSVC):
Indices of support vectors.

support_vectors_ : ndarray of shape (n_SV, n_features)
Support vectors.
Support vectors. An empty array will be returned with a precomputed kernel.
Copy link
Member

@adrinjalali adrinjalali Jul 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Support vectors. An empty array will be returned with a precomputed kernel.
Support vectors. An empty array if kernel is precomputed.

@rprkh
Copy link
Contributor Author

rprkh commented Jul 20, 2023

Added the changes.

@adrinjalali adrinjalali merged commit 399131c into scikit-learn:main Jul 21, 2023
@rprkh rprkh deleted the doc_svm branch July 21, 2023 09:45
punndcoder28 pushed a commit to punndcoder28/scikit-learn that referenced this pull request Jul 29, 2023
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 18, 2023
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc should mentioned that support vector will be empty with precomputed kernel
2 participants