DOC Add links to preprocessing examples in docstrings and userguide #26877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArturoAmorQ
reviewed
Jul 28, 2023
There was a problem hiding this comment.
Thanks for the PR @StefanieSenger. Here is a first batch of comments.
ArturoAmorQ
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
Apart from a bit of wording, LGTM :) Thanks again @StefanieSenger!
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
adrinjalali
reviewed
Jul 31, 2023
|
Resolved the CI issues, thank you @adrinjalali |
adrinjalali
reviewed
Aug 18, 2023
ogrisel
reviewed
Aug 22, 2023
There was a problem hiding this comment.
Overall, LGTM, thanks for the PR. In addition to @adrinjalali's remarks here are a few more.
sklearn/preprocessing/_data.py
Outdated
| @@ -291,6 +290,10 @@ class MinMaxScaler(OneToOneFeatureMixin, TransformerMixin, BaseEstimator): | |||
| This transformation is often used as an alternative to zero mean, | |||
| unit variance scaling. | |||
|
|
|||
| MinMaxScaler doesn't reduce the effect of outliers; it only linearily | |||
| scales them down. For an example visualization, refer to :ref:`Compare | |||
There was a problem hiding this comment.
This statement holds for all scalers (StandardScaler, RobustScaler, MaxAbsScaler and MinMaxScaler). What is different is that the scale value found by RobustScaler is not sensitive to the presence of a few large marginal outliers while it is for StandardScaler and even more so for MinMaxScaler and MaxAbsScaler.
There was a problem hiding this comment.
Yes, I see. To express how the MinMaxScaler differs from the other scalers concerning outliers, I have tried to come up with a new wording:
`MinMaxScaler` doesn't reduce the effect of outliers, but it linearily
scales them down into a fixed range, where the largest occuring data point
corresponds to the maximum value and the smallest one corresponds to the
minimum value.
What do you think?
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
…er/scikit-learn into link_examples_preprocessing
adrinjalali
approved these changes
Aug 24, 2023
akaashpatelmns
pushed a commit
to akaashp2000/scikit-learn
that referenced
this pull request
Aug 25, 2023
…cikit-learn#26877) Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com> Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Aug 29, 2023
…cikit-learn#26877) Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com> Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 18, 2023
…cikit-learn#26877) Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com> Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
jeremiedbb
pushed a commit
that referenced
this pull request
Sep 20, 2023
…26877) Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com> Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
…cikit-learn#26877) Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com> Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests to add links to the examples from the Preprocessing section to the docstrings of the respective classes and functions.