MAINT Minor adjustments to array_api usage in PCA #26898
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Micky774
reviewed
Jul 26, 2023
| @@ -275,8 +275,7 @@ def randomized_range_finder( | |||
| # from float64 to float32 in asarray might not always be accepted as only | |||
| # casts following type promotion rules are guarateed to work. | |||
| # https://github.com/data-apis/array-api/issues/647 | |||
| if is_array_api_compliant: | |||
| Q = xp.asarray(Q, device=device(A)) | |||
| Q = xp.asarray(Q, device=device(A)) | |||
There was a problem hiding this comment.
I think we may still need the compliance check for use on sparse data (current test failures).
Suggested change
| Q = xp.asarray(Q, device=device(A)) | |
| if is_array_api_compliant: | |
| Q = xp.asarray(Q, device=device(A)) |
Micky774
reviewed
Jul 26, 2023
Comment on lines
-866
to
+865
| device = getattr(u, "device", None) | ||
| u_device = device(u) |
There was a problem hiding this comment.
Directly using device fails for dataframes. If device = getattr(u, "device", None) represent the semantics we want, we could modify the device function directly to do the same.
|
I prefer not to abstract |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Follow up to #26315
What does this implement/fix? Explain your changes.
Small adjustments to use less branching and functionality from our
_array_apimodule.