MAINT Parameters validation for sklearn.cluster.dbscan #26920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging with |
adrinjalali
approved these changes
Jul 27, 2023
punndcoder28
pushed a commit
to punndcoder28/scikit-learn
that referenced
this pull request
Jul 29, 2023
…26920) Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
…26920) Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #24862, following up on #24866
What does this implement/fix? Explain your changes.
Added comment to document
sklearn.cluster.dbscanas a public function that does not require automatic parameters validationAny other comments?
This is a follow-up of PR #24866 where it was decided that the annotator for parameter validation was not necessary since the validation is done by DBSCAN class. I am adding the same comment used in another similar case (#25897)