Skip to content

DOC Note missing value support as advantage of decision trees #26928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fabianegli
Copy link
Contributor

Reference Issues/PRs

Fixes #26925.

What does this implement/fix? Explain your changes.

Replaces the previous note of decision trees not supporting missing values with a note and link to the missing value support section in the same document. Missing value support was added in v1.3 of scikit-learn.

@github-actions
Copy link

github-actions bot commented Jul 28, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 6819856. Link to the linter CI: here

@fabianegli
Copy link
Contributor Author

Linting passed, but I am not ReST crack and a pair of human eyes are more than welcome to check.

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @fabianegli !

@thomasjpfan thomasjpfan changed the title [DOC] Note missing value support as advantage of decision trees DOC Note missing value support as advantage of decision trees Jul 28, 2023
fabianegli and others added 2 commits July 28, 2023 17:25
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
@fabianegli
Copy link
Contributor Author

@thomasjpfan Thank you for the review 🙇‍♂️

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update!

@thomasjpfan thomasjpfan added the To backport PR merged in master that need a backport to a release branch defined based on the milestone. label Jul 28, 2023
@thomasjpfan thomasjpfan added this to the 1.3.1 milestone Jul 28, 2023
@thomasjpfan thomasjpfan merged commit 2b0eef8 into scikit-learn:main Jul 28, 2023
@fabianegli fabianegli deleted the docs-tree-missing-value-support branch July 28, 2023 22:31
punndcoder28 pushed a commit to punndcoder28/scikit-learn that referenced this pull request Jul 29, 2023
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 18, 2023
jeremiedbb pushed a commit that referenced this pull request Sep 20, 2023
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation To backport PR merged in master that need a backport to a release branch defined based on the milestone.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Missing values are now supported in Decision Trees
2 participants