Skip to content

DOC Add link to plot_classifier_chain_yeast example in ClassifierChain #26937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 12, 2023

Conversation

Tialo
Copy link
Contributor

@Tialo Tialo commented Jul 29, 2023

Reference Issues/PRs

This adds link to example of multilabel as mentioned in #26927

What does this implement/fix? Explain your changes.

Any other comments?

@github-actions
Copy link

github-actions bot commented Jul 29, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: cbbcba4. Link to the linter CI: here

Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Tialo

Also note that the example itself could be very much improved by making it a notebook style example like the one here: #26805

You can do that in a separate PR.

Tialo and others added 3 commits July 31, 2023 13:26
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
@Tialo Tialo force-pushed the docs/add-multioutput branch from b56b3cd to 8111f12 Compare July 31, 2023 10:26
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Tialo
Copy link
Contributor Author

Tialo commented Jul 31, 2023

Also should I update the branch or you will do it when you will merge it?

@adrinjalali
Copy link
Member

@Tialo no need to update the branch in this case.

@adrinjalali adrinjalali requested a review from glemaitre August 2, 2023 14:17
@glemaitre glemaitre merged commit 5eba9b5 into scikit-learn:main Aug 12, 2023
@glemaitre
Copy link
Member

LGTM Thanks @Tialo Merging.

@Tialo Tialo deleted the docs/add-multioutput branch August 12, 2023 10:30
TamaraAtanasoska pushed a commit to TamaraAtanasoska/scikit-learn that referenced this pull request Aug 21, 2023
akaashpatelmns pushed a commit to akaashp2000/scikit-learn that referenced this pull request Aug 25, 2023
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 18, 2023
jeremiedbb pushed a commit that referenced this pull request Sep 20, 2023
#26937)

Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants