Skip to content

DOC Add link to plot_optics.py #26970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 15, 2023
Merged

Conversation

tanjina-hub
Copy link
Contributor

@tanjina-hub tanjina-hub commented Aug 1, 2023

Towards #26927

Add link to plot_optics.py

#pyladies-sprint

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: b7a079b. Link to the linter CI: here

@adrinjalali adrinjalali changed the title my first open source contribution DOC Add link to plot_optics.py Aug 2, 2023
Comment on lines 12 to 13
For an example of usage, see
:ref:`sphx_glr_auto_examples_cluster_plot_optics.py`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to go to the docstring of the OPTICS class, rather than here, which is in _optics.py

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adrinjalali I followed your instruction but I really don't getting why some checks failed at the test?

@@ -53,6 +53,9 @@ class OPTICS(ClusterMixin, BaseEstimator):

Read more in the :ref:`User Guide <optics>`.

For an example of usage, see
:ref:`sphx_glr_auto_examples_plot_cluster_optics.py`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: undefined label: 'sphx_glr_auto_examples_plot_cluster_optics.py'

change it to:

    :ref:`sphx_glr_auto_examples_cluster_plot_optics.py`.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@greyisbetter Thanks, I tried your suggestion but still there is 2 failing checks in the test.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using less extra spaces between paragraph may help. And I think it would be better if the example is at the end of the docstring.

Copy link
Contributor

@greyisbetter greyisbetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try suggestion or simply run the command given below in your terminal before pushing:

black <path to _optics.py file>

@@ -51,8 +51,7 @@ class OPTICS(ClusterMixin, BaseEstimator):
cluster order. Note that we do not employ a heap to manage the expansion
candidates, so the time complexity will be O(n^2).

Read more in the :ref:`User Guide <optics>`.

Read more in the :ref:`User Guide <optics>`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Read more in the :ref:`User Guide <optics>`.
Read more in the :ref:`User Guide <optics>`.

Comment on lines 235 to 236

For an example of usage, see :ref:`sphx_glr_auto_examples_cluster_plot_optics.py`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For an example of usage, see :ref:`sphx_glr_auto_examples_cluster_plot_optics.py`.
For an example of usage, see
:ref:`sphx_glr_auto_examples_cluster_plot_optics.py`.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@greyisbetter Thanks, I tried to follow all of the suggestion but still somehow it couldn't pass all the checks!

@adrinjalali adrinjalali enabled auto-merge (squash) August 15, 2023 14:45
@adrinjalali adrinjalali merged commit dadabb5 into scikit-learn:main Aug 15, 2023
@tanjina-hub tanjina-hub deleted the Tanjina_branch branch August 15, 2023 15:56
TamaraAtanasoska pushed a commit to TamaraAtanasoska/scikit-learn that referenced this pull request Aug 21, 2023
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
akaashpatelmns pushed a commit to akaashp2000/scikit-learn that referenced this pull request Aug 25, 2023
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 18, 2023
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
jeremiedbb pushed a commit that referenced this pull request Sep 20, 2023
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants