DOC improve iris example #26973
DOC improve iris example #26973
Conversation
❌ Linting issuesThere was an issue running the linter job. Please update with |
There was a problem hiding this comment.
There's also something in the docstring to be fixed: https://dev.azure.com/scikit-learn/scikit-learn/_build/results?buildId=57560&view=logs&j=78a0bf4f-79e5-5387-94ec-13e67d216d6e&t=f1857171-4a53-55c7-3ab5-90acfe091baa&l=1097
…(as suggested by Guillaume)
…gested by Guillaume)
…y, assigning them is confusing. Also stick to default colors to make example easier
|
Thanks @glemaitre for your comments! |
…t-learn into doc_improve_iris_example
…e can better describe the types
| # %% | ||
| # Scatter Plot of the Iris dataset | ||
| # -------------------------------- | ||
| import matplotlib.pyplot as plt # noqa: E402 |
There was a problem hiding this comment.
| import matplotlib.pyplot as plt # noqa: E402 | |
| import matplotlib.pyplot as plt |
There was a problem hiding this comment.
I had to leave this in, otherwise the linter would not let me commit
There was a problem hiding this comment.
This is weird, because our global conf already discard E402.
I committed and pushed with the fix and it seems that pre-commit did not annoy me. Not sure why you got in trouble.
…t-learn into doc_improve_iris_example
|
Thanks for the helpful comments @glemaitre ! |
|
Good for merging. Thanks @eguenther |
Co-authored-by: Elisabeth Günther <eguenther@MacBook-Pro-von-Elisabeth.local> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Elisabeth Günther <eguenther@MacBook-Pro-von-Elisabeth.local> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Elisabeth Günther <eguenther@MacBook-Pro-von-Elisabeth.local> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Adds a link to the plot_iris_dataset example (#26927 ) to make it more discoverable.
Thanks @adrinjalali @glemaitre