-
-
Notifications
You must be signed in to change notification settings - Fork 26k
DOC improve iris example #26973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
glemaitre
merged 28 commits into
scikit-learn:main
from
eguenther:doc_improve_iris_example
Sep 7, 2023
Merged
DOC improve iris example #26973
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
7c728e0
typo
b289185
add link to the example
c6b6026
adapt wording: pca dimension instead of direction
eguenther ea18244
adapt PCA section
eguenther edec869
adapt format and correct a typo
eguenther 2e0d8ed
fix docstring
eguenther 0f2e5dd
add explanations to the plots
eguenther 465ddf0
Merge branch 'main' into doc_improve_iris_example
eguenther d096b26
remove empty line in docstring (as suggested by guillaume)
eguenther f81572b
adapt divider lines to fit text length (as suggested by Guillaume)
eguenther a3d2bc9
move matplotlib import into the cell where it is used the first time …
eguenther 3f8731e
move PCA import into the cell where it is used the first time (as sug…
eguenther d752fe6
clean up code for better readability. First plot does not need X and …
eguenther 7b3dc5e
remove typos: the 't' key on my keyboard is stuck :-/
eguenther 259a009
adapt text for PCA (intro and plot description), as suggested by Guil…
eguenther cfe9790
adapt title for first cell
eguenther cd3f95b
Merge branch 'main' into doc_improve_iris_example
eguenther 326bfd5
adjust scatter plot to Guillaumes suggestion
eguenther f0db197
Merge branch 'doc_improve_iris_example' of github.com:eguenther/sciki…
eguenther 1ff67e0
improve text for the scatter plot: now that we have added a legend, w…
eguenther db80506
trying to fix the failed checks: add empty line before next cell
eguenther 1116fd5
Merge branch 'main' into doc_improve_iris_example
eguenther 3546484
add new cell for comments
eguenther d83f0e5
remove the part where the plot size was specified, we don't need it
eguenther 57b5be9
add noqa because import is not done at the top of the file!
eguenther c2acef8
Merge branch 'doc_improve_iris_example' of github.com:eguenther/sciki…
eguenther 5764d95
Merge branch 'main' into doc_improve_iris_example
eguenther 474e8cc
MAINT remove unecessary check
glemaitre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.