FIX Pop unnecessary elements from metric_kwargs in datasets_pair.pyx.tp
#26987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @jjerphan @OmarManzoor in case either of you are interested in reviewing |
glemaitre
reviewed
Aug 2, 2023
| if metric_kwargs is not None: | ||
| # Copying metric_kwargs not to pop "X_norm_squared" | ||
| # and "Y_norm_squared" where they are used | ||
| metric_kwargs = copy.copy(metric_kwargs) |
There was a problem hiding this comment.
quick question: does metric_kwargs can have nested objects such that calling deepcopy instead of copy could be better?
There was a problem hiding this comment.
Here, we do not want to copy the objects themselves, (which is what deepcopy does), and only want to copy their reference in another dictionary (which is what copy does).
What do you think? Is this right?
Probably we could include a comment to explain the function that is used.
There was a problem hiding this comment.
OK right, metric_kwargs will only be used "read-only", that makes sense.
glemaitre
approved these changes
Aug 2, 2023
9Y5
pushed a commit
to 9Y5/scikit-learn
that referenced
this pull request
Aug 2, 2023
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
This change was first made in #25561 by @jjerphan and @Vincent-Maladiere
What does this implement/fix? Explain your changes.
Any other comments?
I factored this out separately so as to simplify the new PR (#26983)