Skip to content

ENH handle mutliclass with scores and probailities in DecisionBoundaryDisplay #26995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

glemaitre
Copy link
Member

While reviewing #26978, I thought that we should support predict_proba and decision_function for the multiclass case by requesting class_label.

I change the example to see the simplification. Also, it provides a solution to the # TODO support pos_label since class_label can also be used in the binary case to switch the positive class.

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 4038deb. Link to the linter CI: here

Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments, otherwise LGTM.

@adrinjalali
Copy link
Member

CI failing.

@glemaitre
Copy link
Member Author

closing in favor of #27291

@glemaitre glemaitre closed this Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants