-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
ENH handle mutliclass with scores and probailities in DecisionBoundaryDisplay #26995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
glemaitre
wants to merge
7
commits into
scikit-learn:main
from
glemaitre:boundary_display_multiclass
Closed
ENH handle mutliclass with scores and probailities in DecisionBoundaryDisplay #26995
glemaitre
wants to merge
7
commits into
scikit-learn:main
from
glemaitre:boundary_display_multiclass
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
reviewed
Aug 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comments, otherwise LGTM.
sklearn/inspection/_plot/tests/test_boundary_decision_display.py
Outdated
Show resolved
Hide resolved
CI failing. |
closing in favor of #27291 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #26978, I thought that we should support
predict_proba
anddecision_function
for the multiclass case by requestingclass_label
.I change the example to see the simplification. Also, it provides a solution to the
# TODO support pos_label
sinceclass_label
can also be used in the binary case to switch the positive class.