CI Build and test Python 3.12 wheels #27027

lesteve · 2023-08-07T11:42:59Z

github-actions · 2023-08-07T11:44:57Z

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

_{Generated for commit: 12078b2. Link to the linter CI: here}

thomasjpfan · 2023-08-07T13:26:27Z

.github/workflows/wheels.yml

          CIBW_ENVIRONMENT: SKLEARN_SKIP_NETWORK_TESTS=1
                            SKLEARN_BUILD_PARALLEL=3
+                            PIP_EXTRA_INDEX_URL=https://pypi.anaconda.org/scientific-python-nightly-wheels/simple


Given the CI issues, I think we should set PIP_EXTRA_INDEX_URL only for Python 3.12. Otherwise, the other jobs will pick it up and try to build packages from source.

In general, I think it's better to isolate these environment variables to Python 3.12.

Do you have any suggestions on how to do this without too much pain? Would it be at the github actions (or Cirrus) level, finding a way to define a variable depending on which matrix entry we are in?

I would expand the matirx configuration for 3.12 with a new prerelease item:

- os: macos-latest python: 311 platform_id: macosx_arm64 prerelease: True

and then add it to the env:

CIBW_PRERELEASE_PYTHONS: ${{ matrix.prerelease }}

Then updated build_wheels.sh to adjust CIBW_ENVIRONMENT based on CIBW_PRERELEASE_PYTHONS.

thomasjpfan · 2023-08-07T19:35:10Z

.github/workflows/wheels.yml

          CIBW_ENVIRONMENT: SKLEARN_SKIP_NETWORK_TESTS=1
                            SKLEARN_BUILD_PARALLEL=3
+                            PIP_EXTRA_INDEX_URL=https://pypi.anaconda.org/scientific-python-nightly-wheels/simple


I would expand the matirx configuration for 3.12 with a new prerelease item:

- os: macos-latest python: 311 platform_id: macosx_arm64 prerelease: True

and then add it to the env:

CIBW_PRERELEASE_PYTHONS: ${{ matrix.prerelease }}

Then updated build_wheels.sh to adjust CIBW_ENVIRONMENT based on CIBW_PRERELEASE_PYTHONS.

build_tools/cirrus/arm_wheel.yml

thomasjpfan · 2023-08-07T19:37:48Z

build_tools/github/build_minimal_windows_image.sh

@@ -14,6 +14,10 @@ cp $WHEEL_PATH $WHEEL_NAME
 # Dot the Python version for identyfing the base Docker image
 PYTHON_VERSION=$(echo ${PYTHON_VERSION:0:1}.${PYTHON_VERSION:1:2})

+# TODO: remove this when Python 3.12 is released
+if [[ "$PYTHON_VERSION" == "3.12" ]]; then


Can we condition on CIBW_PRERELEASE_PYTHONS == True here to and add the "-rc"?

When 3.12 gets released, we just have to remove prerelease from the build matrix, without needing to update this script anymore.

….12 build

lesteve · 2023-08-08T15:56:28Z

There are some failures in the Python 3.12 builds but they are also in main with numpy development version see #27042.

I will wait for pandas to upload a Python 3.12 wheel to scientific-python-nightly-builds pandas-dev/pandas#54447 so this can be added back to CIBW_TESTING_REQUIRES. pandas is waiting for numpy 1.26 release which should happen soonish since Python 3.12 release candidate has been released.

build_tools/cirrus/arm_wheel.yml

This reverts commit 893d0b4.

lesteve · 2023-09-08T12:54:20Z

Pandas has started uploading a python 3.12 wheel to scientific-python-nightly-wheels so I gave it another go.

There does not seem to be any issue with python 3.12 as far as I can see:

failure on Linux and Windows, one is a known issue in scipy dev ENH: change sparse dok from subclass of dict to have attribute dict scipy/scipy#18929 (comment). The other is because setuptools is not installed anymore when creating a virtual env with python 3.12 (see https://docs.python.org/3.12/library/venv.html#creating-virtual-environments) and some of our tests need setuptools
there are some builds failing with ImportError: cannot import name 'ComplexWarning' from 'numpy' because on some platforms the scipy development wheel has not been uploaded in a while (arm on Linux and OSX). To reduce Cirrus usage arm scipy wheels are uploaded every 3rd Saturday of the month, see Nightly wheels built on CirrusCI are not uploaded to scientific-python-nightly-wheels scipy/scipy#19221 (comment).

I am not too sure how we want to proceed forward on this:

if we think this is important to upload a scikit-learn nightly wheel for Python 3.12, then we can uploading without testing it as suggested in CI Build and test Python 3.12 wheels #27027 (comment)
we wait until there are releases of numpy (1.26 soonish) and scipy (not sure about the timings) that support Python 3.12, to start uploading python 3.12 nightly wheels

…nto python-3.12-wheels

thomasjpfan

From looking at the most recent build logs, the linux build error looks real and the windows one is from building pandas from source.

I think it's important to fix the linux issue, but we can leave the windows build for when pandas releases a wheel for 3.12.

lesteve · 2023-09-19T19:35:24Z

The setuptools dependency issue should be fixed (for real this time hopefully) in #27420

That should fix the Linux build.

…nto python-3.12-wheels

lesteve · 2023-09-25T11:41:37Z

Now that pandas has Python 3.12 wheels in its latest release (2.1.1), this makes it easier for us.

This is only testing on Python 3.12 for CirrusCI as suggested in #27027 (review)

Do we want to upload Python 3.12 wheels for scikit-learn 1.3.1? FYI Python 3.12 release is scheduled for October 2.

EwoutH · 2023-09-26T11:14:36Z

Do we want to upload Python 3.12 wheels for scikit-learn 1.3.1

I think this would be really great, having stable Python 3.12 wheels on release!

EwoutH · 2023-09-27T10:10:28Z

build_tools/cirrus/arm_wheel.yml

-        CIBW_BUILD: cp311-macosx_arm64
+        CIBW_BUILD: cp312-macosx_arm64
+        # TODO: remove when Python 3.12 is released
+        CIBW_PRERELEASE_PYTHONS: True


This can now be removed, since cibuildwheel v2.15.0 CPython 3.12 wheels are built by default.

Thanks, good to know!

I'd rather wait for Python 3.12 to be released before removing all of them because we rely on CI_BW_PRERELEASE_PYTHONS on Windows for building the custom Docker image.

glemaitre · 2023-09-28T09:15:28Z

Do we want to upload Python 3.12 wheels for scikit-learn 1.3.1? FYI Python 3.12 release is scheduled for October 2.

As discussed in the monthly meeting, we are aiming at uploading the wheels.

glemaitre

@lesteve Could you update the setup.py metadata and add that we support Python 3.12 meaning:

            "Programming Language :: Python :: 3",
            "Programming Language :: Python :: 3.8",
            "Programming Language :: Python :: 3.9",
            "Programming Language :: Python :: 3.10",
            "Programming Language :: Python :: 3.11",
            "Programming Language :: Python :: 3.12",

It would allow to update the badge at the same time.

glemaitre

LGTM on my side. @ogrisel @thomasjpfan do you want to have a new look.
Once merge, I will figure out what is needed to upload the new wheel on PyPI and build the binary in conda-forge.

lesteve · 2023-09-28T09:46:49Z

Something I am thinking of only now, these two PRs removing the setuptools dependency in our test suite will probably need to be backported too (in this order) #27355 #27420

glemaitre · 2023-09-28T10:15:05Z

Yep, there are already back-ported indeed: https://github.com/scikit-learn/scikit-learn/commits/1.3.X

EwoutH · 2023-09-29T22:13:35Z

Any chance wheels could be uploaded to PyPI (maybe even manually) before Python 3.12.0 releases Monday (2023-10-02)?

ogrisel

LGTM with the updated comments.

build_tools/cirrus/arm_wheel.yml

ogrisel · 2023-10-02T10:05:53Z

.github/workflows/wheels.yml

@@ -114,6 +125,9 @@ jobs:
          - os: macos-latest
            python: 310
            platform_id: macosx_arm64
+          - os: macos-latest


Please update line 118 above to something like:

# MacOS arm64 # The wheel for the latest Python version is built and tested on # Cirrus CI but due to limited build time for free accounts on Cirrus # CI, we build the macOS arm64 wheels for the other Python versions on # Github Actions via cross-compilation (without running the tests).

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>

ogrisel · 2023-10-02T12:03:20Z

Thanks @lesteve!

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>

lesteve added 2 commits August 7, 2023 13:39

CI Build and test Python 3.12 wheels

314db4f

[cd build] [azure parallel]

d189546

github-actions bot added the Build / CI label Aug 7, 2023

thomasjpfan reviewed Aug 7, 2023

View reviewed changes

[cd build] Tweak Windows docker image for Python 3.12

3252a61

thomasjpfan reviewed Aug 7, 2023

View reviewed changes

lesteve added 11 commits August 8, 2023 09:55

Upgrade pip needed for Python 3.12

c18cd23

[cd build] Use development numpy and scipy versions only for Python 3…

7a2f3f1

….12 build

[cd build] Tweak windows script

860b8d5

[cd build] Tweak

5de909c

[cd build] Temporarily remove pandas install

893d0b4

[cd build] Fix

52c6e07

[cd build]

e076756

[cd build]

ab63ef2

[cd build] Tweak

3c8912f

[cd build] temporarily remove lingering pandas

2056347

[cd build] use powershell

5a71325

lesteve added No Changelog Needed and removed No Changelog Needed labels Aug 8, 2023

[cd build] add ARG to Dockerfile

2b85fa0

thomasjpfan reviewed Aug 9, 2023

View reviewed changes

build_tools/cirrus/arm_wheel.yml Show resolved Hide resolved

build_tools/cirrus/arm_wheel.yml Show resolved Hide resolved

lesteve added 2 commits September 8, 2023 10:50

Revert "[cd build] Temporarily remove pandas install"

5f00fa0

This reverts commit 893d0b4.

[cd build] apply suggestions

8b273f6

lesteve added 4 commits September 8, 2023 16:52

[cd build] Windows fix?

97aae36

Merge branch 'main' of https://github.com/scikit-learn/scikit-learn i…

ebc39f5

…nto python-3.12-wheels

[cd build]

22df811

Merge branch 'main' of https://github.com/scikit-learn/scikit-learn i…

ead0731

…nto python-3.12-wheels

[cd build gh] Windows fix

05a7aaf

thomasjpfan reviewed Sep 19, 2023

View reviewed changes

lesteve added 6 commits September 20, 2023 08:25

Merge branch 'main' of https://github.com/scikit-learn/scikit-learn i…

58c1ec0

…nto python-3.12-wheels

[cd build] trigger CI

c7d31bd

pandas has a release with Python 3.12 wheel

7577932

fix

ae225d3

Skip test on Python 3.11 arm

5b0e18d

[cd build] trigger CI

1d79d89

lesteve marked this pull request as ready for review September 25, 2023 11:34

glemaitre self-requested a review September 26, 2023 13:59

EwoutH reviewed Sep 27, 2023

View reviewed changes

glemaitre reviewed Sep 28, 2023

View reviewed changes

Update metadata for Python 3.12

bc92239

glemaitre approved these changes Sep 28, 2023

View reviewed changes

ogrisel approved these changes Oct 2, 2023

View reviewed changes

lesteve and others added 2 commits October 2, 2023 12:40

Update build_tools/cirrus/arm_wheel.yml

dd0d4f8

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>

Add comment

12078b2

ogrisel merged commit 93e22cd into scikit-learn:main Oct 2, 2023

lesteve deleted the python-3.12-wheels branch October 2, 2023 12:16

glemaitre pushed a commit that referenced this pull request Oct 2, 2023

CI Build and test Python 3.12 wheels (#27027)

5309a51

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>

braniii mentioned this pull request Oct 26, 2023

PEP632: Remove depracted call of distutils.version.LooseVersion scikit-learn-contrib/scikit-learn-extra#141

Open

REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023

CI Build and test Python 3.12 wheels (scikit-learn#27027)

d9a35d7

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CI Build and test Python 3.12 wheels #27027

CI Build and test Python 3.12 wheels #27027

lesteve commented Aug 7, 2023

github-actions bot commented Aug 7, 2023 •

edited

Loading

thomasjpfan Aug 7, 2023

lesteve Aug 7, 2023

thomasjpfan Aug 7, 2023

thomasjpfan Aug 7, 2023

thomasjpfan Aug 7, 2023

lesteve commented Aug 8, 2023 •

edited

Loading

lesteve commented Sep 8, 2023 •

edited

Loading

thomasjpfan left a comment

lesteve commented Sep 19, 2023

lesteve commented Sep 25, 2023 •

edited

Loading

EwoutH commented Sep 26, 2023

EwoutH Sep 27, 2023

lesteve Sep 28, 2023

glemaitre commented Sep 28, 2023

glemaitre left a comment

glemaitre left a comment

lesteve commented Sep 28, 2023 •

edited

Loading

glemaitre commented Sep 28, 2023

EwoutH commented Sep 29, 2023

ogrisel left a comment

ogrisel Oct 2, 2023

ogrisel commented Oct 2, 2023

CI Build and test Python 3.12 wheels #27027

CI Build and test Python 3.12 wheels #27027

Conversation

lesteve commented Aug 7, 2023

github-actions bot commented Aug 7, 2023 • edited Loading

✔️ Linting Passed

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lesteve commented Aug 8, 2023 • edited Loading

lesteve commented Sep 8, 2023 • edited Loading

thomasjpfan left a comment

Choose a reason for hiding this comment

lesteve commented Sep 19, 2023

lesteve commented Sep 25, 2023 • edited Loading

EwoutH commented Sep 26, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

glemaitre commented Sep 28, 2023

glemaitre left a comment

Choose a reason for hiding this comment

glemaitre left a comment

Choose a reason for hiding this comment

lesteve commented Sep 28, 2023 • edited Loading

glemaitre commented Sep 28, 2023

EwoutH commented Sep 29, 2023

ogrisel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ogrisel commented Oct 2, 2023

github-actions bot commented Aug 7, 2023 •

edited

Loading

lesteve commented Aug 8, 2023 •

edited

Loading

lesteve commented Sep 8, 2023 •

edited

Loading

lesteve commented Sep 25, 2023 •

edited

Loading

lesteve commented Sep 28, 2023 •

edited

Loading