-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
DOC take Examples
out of a dropdown
#27034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC take Examples
out of a dropdown
#27034
Conversation
Sorry, I updated 4 times, because I did not understand the update work flow. |
A message "This branch is out-of-date with the base branch" appears. |
Thanks for the PR @hiramatsuyuusuke. Maybe you can convert the section
In general you don't have do it, except is the CI is failing on our side or if the file concerned by the PR has conflicts. In any other case triggering the tests just consumes computational resources. |
Thanks for the review and advice, @ArturoAmorQ. And if there are no mistakes, I follow these steps: |
To reviewer @ArturoAmorQ. I made a separate dropdown Additionally, I trigger the tests, because the file was changed. Were these tests necessary? |
Examples
out of a dropdown (#26617, #26641)Examples
out of a dropdown
Sorry for taking so long to answer. Triggering the tests is not necessary if you changed the file, it is only necessary if the file was changed by another PR and it is generating a conflict. You can also re-trigger the tests if they are failing and the error message does not seem related to your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In any case this PR LGTM :) thanks for your work @hiramatsuyuusuke, merging this one!
Reference Issues/PRs
(#26617, #26641)
What does this implement/fix? Explain your changes.
I fix
scikit-learn\doc\modules\svm.rst
.A drop down of
Custom Kernels
in 1.4. Support Vector Machines(#26617) folds aExamples
.So I take a
Examples
out of a dropdown.Then I added a drop down of
Using the Gram matrix
.See also . #26641.
Any other comments?
There is a folded
Examples
in 1.4. Support Vector Machines.So, I worked on 1.4. Support Vector Machines to fix a folded Examples.
I think #26641 was finish. So, I think this is a correct handover.