Skip to content

Add mps device in Array API tests #27098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 18, 2023
Merged

Add mps device in Array API tests #27098

merged 10 commits into from
Aug 18, 2023

Conversation

EdAbati
Copy link
Contributor

@EdAbati EdAbati commented Aug 18, 2023

(PR part of the Sprint at EuroSciPy 2023)

While trying to contribute to the #22352 effort, I have realised that the mps device (the GPU device name in PyTorch for Mac with M1/M2) was not part of the Array API tests. I added this here.
Thanks to @ogrisel for the help with this :)

@github-actions
Copy link

github-actions bot commented Aug 18, 2023 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: ff44125. Link to the linter CI: here

betatim
betatim approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@betatim betatim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment, but otherwise LGTM

ogrisel
ogrisel approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well. @betatim @EdAbati I pushed a few additional commits to update the changelog and the documentation. Please feel free to suggest rewording if not clear.

betatim
betatim reviewed Aug 18, 2023
View reviewed changes
@ogrisel ogrisel enabled auto-merge (squash) August 18, 2023 14:28
@ogrisel ogrisel merged commit ccf7d53 into scikit-learn:main Aug 18, 2023
@EdAbati EdAbati deleted the add-mps-in-array-api-tests branch August 18, 2023 14:45
TamaraAtanasoska pushed a commit to TamaraAtanasoska/scikit-learn that referenced this pull request Aug 21, 2023
@EdAbati @ogrisel @TamaraAtanasoska
Add mps device in Array API tests (scikit-learn#27098)
8665663 
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
akaashpatelmns pushed a commit to akaashp2000/scikit-learn that referenced this pull request Aug 25, 2023
@EdAbati @ogrisel @akaashpatelmns
Add mps device in Array API tests (scikit-learn#27098)
74daec7 
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@EdAbati @ogrisel @REDVM
Add mps device in Array API tests (scikit-learn#27098)
3a9a66d 
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@betatim betatim betatim approved these changes

Assignees
No one assigned
Labels
Array API module:decomposition module:utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EdAbati @ogrisel @betatim