-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
DOC remove obsolete SVM example #27108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -299,6 +299,7 @@ | |||
"auto_examples/decomposition/plot_beta_divergence": ( | |||
"auto_examples/applications/plot_topics_extraction_with_nmf_lda" | |||
), | |||
"auto_examples/svm/plot_svm_nonlinear": "auto_examples/svm/plot_svm_kernels", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As noted in #26972 (comment), the XOR problem is the canonical example for non-linear decision functions.
I agree that auto_examples/svm/plot_svm_kernels
illustrates similar motivations but I would rather redirect to an example that also includes the canonical XOR, maybe with more models / kernels as suggested by Guillaume.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ogrisel Do you think these days this example is still relevant? I would rather people read more realistic examples instead. Is there another example you prefer to be here instead?
I also don't really see a way where users would actually benefit from this redirection. Our example pages don't have a link to the same example in the new release. The only link we provide is to the home page of the latest release, not the same page in the latest release. So I'd be happy to remove these redirections altogether.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about adding XOR to classifier comparison, wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be inclined to have this dataset because this is still an interesting synthetic one. Probably the classification one is the right place to have it. For instance, this is part of the default dataset in this playground (https://playground.tensorflow.org)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So let's remove this one, and put the dataset into an existing one. We really have too many examples!
Just commenting to say that I will start looking into implementing the suggestions from the comments of this issue into a new, updated example. |
If |
@marenwestermann Could NuSVC added in another existing example? The general idea is to have less examples. |
@lorentzenchr yes, adding an example of NuSVC to an existing example is also a good idea in my opinion. @ogrisel What's your opinion on this? |
This now adds the XOR pattern to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks to have keep the XOR in one example. I think that it fits well in the kernel example.
Closes #26972
xref: #26972 (comment) and #27151
This example is pretty useless and outdated. Can simply be removed.
cc @glemaitre