Skip to content

DOC add link to plot_cv_indices example in _split #27244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 17, 2023
Merged

DOC add link to plot_cv_indices example in _split #27244

merged 3 commits into from
Sep 17, 2023

Conversation

MN193
Copy link
Contributor

@MN193 MN193 commented Aug 30, 2023

Reference Issues/PRs

Towards to issue #26927

What does this implement/fix?

Adds links to examples\model_selection\plot_cv_indices.py for the following classes in sklearn\model_selection\_split.py:

  • GroupKFold
  • GroupShuffleSplit
  • KFold
  • ShuffleSplit
  • StratifiedGroupKFold
  • StratifiedKFold
  • StratifiedShuffleSplit
  • TimeSeriesSplit

Any other comments?

Ping @adrinjalali

@github-actions
Copy link

github-actions bot commented Aug 30, 2023 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: b83833f. Link to the linter CI: here

@adrinjalali adrinjalali mentioned this pull request Sep 11, 2023
Closed
adrinjalali
adrinjalali approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@adrinjalali
Copy link
Member

ping @glemaitre @ArturoAmorQ

@adrinjalali adrinjalali added the Quick Review For PRs that are quick to review label Sep 17, 2023
@glemaitre glemaitre self-requested a review September 17, 2023 10:59
glemaitre
glemaitre approved these changes Sep 17, 2023
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @MN193

@glemaitre glemaitre merged commit a337410 into scikit-learn:main Sep 17, 2023
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 18, 2023
@MN193 @adrinjalali @glemaitre
DOC add link to plot_cv_indices example in _split (scikit-learn#27244)
c63f582 
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 19, 2023
@MN193 @adrinjalali @glemaitre
DOC add link to plot_cv_indices example in _split (scikit-learn#27244)
427092f 
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
jeremiedbb pushed a commit that referenced this pull request Sep 20, 2023
@MN193 @adrinjalali @jeremiedbb
DOC add link to plot_cv_indices example in _split (#27244)
bfe045f 
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@MN193 @adrinjalali @REDVM
DOC add link to plot_cv_indices example in _split (scikit-learn#27244)
4deb2ae 
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrinjalali adrinjalali adrinjalali approved these changes

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
Documentation module:model_selection Quick Review For PRs that are quick to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MN193 @adrinjalali @glemaitre