Added automatic validation function for sklearn.neighbors.radius_neighbors_graph (#24862) #27245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added validation params to sklearn.neighbors.radius_neighbors_graph
Added sklearn.neighbors.radius_neighbors_graph to the test_public_functions list
corrected a comma
|
Hi @jeremiedbb @glemaitre , All the checks have passed, Kindly review the changes made and let me know if there are any modifications to be done. Thanks & Regards Sayed Qaiser Ali |
jeremiedbb
reviewed
Sep 1, 2023
removed changelogs
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
|
Thanks so much for the guidance @jeremiedbb. I have made the changes as you suggested. Kindly review it. |
jeremiedbb
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
I directly pushed to fix the docstring. LGTM. Thanks @sqali
|
Hi @jeremiedbb , I am unable to see the changes, is there some issue? |
What do you mean by that ? Until we merge the PR, the changes are only visible in the PR. Once we merge it (which I just did) then changes are visible in the |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 5, 2023
…s_neighbors_graph (scikit-learn#27245) Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
…s_neighbors_graph (scikit-learn#27245) Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jeremiedbb , @glemaitre
This pull request is raised to add an automatic validation function for sklearn.neighbors.radius_neighbors_graph based on issue #24862. I have also updated the test_public_functions. Kindly check and review the changes made and let me know if they require any modifications.
Thanks & Regards
Saed Qaiser Ali