Skip to content

TST Improve assert_argkmin_results_quasi_equality error message #27281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 39 commits into from
Sep 28, 2023
Merged

TST Improve assert_argkmin_results_quasi_equality error message #27281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
a9f4617
test: Improve `assert_argkmin_results_quasi_equality` error message
jjerphan Sep 3, 2023
a2b9a80
Trigger [all random seeds] for test_pairwise_distances_argkmin
ogrisel Sep 11, 2023
37df634
[azure parallel] [all random seeds] test_pairwise_distances_argkmin
ogrisel Sep 11, 2023
109db17
Simpler way to assert approximate equality of neighbor results
ogrisel Sep 13, 2023
baa792d
Focus this PR on argkmin tests for now
ogrisel Sep 13, 2023
755f641
Fix edge cases by making check for missing indices symmetric
ogrisel Sep 13, 2023
6a5fa0f
[azure parallel] [all random seeds] test_pairwise_distances_argkmin
ogrisel Sep 13, 2023
9a975b3
Speed-up test_pairwise_distances_* by dividing the number of queries …
ogrisel Sep 14, 2023
04f7bdd
[azure parallel] [all random seeds] test_pairwise_distances
ogrisel Sep 14, 2023
bf08959
Merge branch 'main' into tst/improve-error-message-assert_argkmin_res…
ogrisel Sep 14, 2023
9ec1263
Further speed-up pairwise distance tests by leveraging global random …
ogrisel Sep 14, 2023
21ed726
Simplify assert_argkmin_results_quasi_equality to always use informat…
ogrisel Sep 14, 2023
c66770e
Fix inline comments in test + one more test case to check symmetry of…
ogrisel Sep 14, 2023
2663108
[azure parallel] [all random seeds] test_pairwise_distances
ogrisel Sep 14, 2023
4a498e9
Refactor radius neighbors checks, remove unused code and accelerate p…
ogrisel Sep 14, 2023
36aead5
[azure parallel] [all random seeds] test_pairwise_distances
ogrisel Sep 14, 2023
7887faa
More factorization, easier to understand handling of tols in the tests
ogrisel Sep 14, 2023
70dd933
[azure parallel] [all random seeds] test_pairwise_distances
ogrisel Sep 14, 2023
e8c227a
More interesting tests
ogrisel Sep 14, 2023
9845866
[azure parallel] [all random seeds] test_pairwise_distances
ogrisel Sep 14, 2023
106952a
Fix side effect of the refactoring in test_neighbors
ogrisel Sep 14, 2023
9b57538
More test tweaks to reduce test time while increasing aggregate coverage
ogrisel Sep 14, 2023
30f1901
Optimize the speed of running test_strategies_consistency while keepi…
ogrisel Sep 14, 2023
897fece
Attempt to make test_pairwise_distances_radius_neighbors more useful …
ogrisel Sep 14, 2023
d23210b
Fix side effect of the heuristic radius computation
ogrisel Sep 14, 2023
f2d9725
Accelerate test_n_threads_agnosticism by using a data-drive radius value
ogrisel Sep 14, 2023
ec263ca
Accelerate test_format_agnosticism and test_chunk_size_agnosticism by…
ogrisel Sep 14, 2023
f43d5cb
Do not rely on implicit data conversion in test_kneighbors_brute_backend
ogrisel Sep 15, 2023
f04a190
Merge branch 'main' into tst/improve-error-message-assert_argkmin_res…
ogrisel Sep 15, 2023
f2d8d8e
[azure parallel] [all random seeds] test_pairwise_distances
ogrisel Sep 15, 2023
e85d81b
Typo: if metric in metric in ...
ogrisel Sep 15, 2023
119c923
Merge branch 'main' into tst/improve-error-message-assert_argkmin_res…
ogrisel Sep 16, 2023
c01255e
Typos and code style improvements
ogrisel Sep 26, 2023
05234d4
Factorize redundant test logic to find a non-trivial test radius
ogrisel Sep 26, 2023
40b305e
Merge branch 'main' into tst/improve-error-message-assert_argkmin_res…
ogrisel Sep 26, 2023
d0dfbf2
Merge branch 'main' into tst/improve-error-message-assert_argkmin_res…
ogrisel Sep 26, 2023
1224fb6
Apply suggestions from code review
ogrisel Sep 27, 2023
7fb4261
DOC add missing docstring + improve inline comment
ogrisel Sep 27, 2023
4a0592a
Merge branch 'main' into tst/improve-error-message-assert_argkmin_res…
ogrisel Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading