Skip to content

MAINT better fused type names in loss module #27330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2023
Merged

MAINT better fused type names in loss module #27330

merged 1 commit into from
Sep 11, 2023

Conversation

lorentzenchr
Copy link
Member

Reference Issues/PRs

Related to #25572.

@github-actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: f4cd8c0. Link to the linter CI: here

@lorentzenchr lorentzenchr changed the title MAINT better fused types names in loss module MAINT better fused type names in loss module Sep 10, 2023
@lorentzenchr
Copy link
Member Author

Question: Let double be double or change to float64_t? I'm leaning more to letting double untouched.

OmarManzoor
OmarManzoor approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @lorentzenchr

@glemaitre glemaitre self-requested a review September 11, 2023 15:55
@glemaitre
Copy link
Member

Question: Let double be double or change to float64_t? I'm leaning more to letting double untouched.

I would let as-is.

glemaitre
glemaitre approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @lorentzenchr

@glemaitre glemaitre merged commit c5f2229 into scikit-learn:main Sep 11, 2023
@lorentzenchr lorentzenchr deleted the mnt_loss_dtype branch September 11, 2023 18:05
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@lorentzenchr @REDVM
MAINT better fused type names in loss module (scikit-learn#27330)
a270d02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre approved these changes

@OmarManzoor OmarManzoor OmarManzoor approved these changes

Assignees
No one assigned
Labels
cython
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lorentzenchr @glemaitre @OmarManzoor