MAINT cython typedefs in sparsefuncs_fast #27333
Conversation
| @@ -15,6 +15,8 @@ | |||
| # use these consistently throughout the codebase. | |||
| # NOTE: Extend this list as needed when converting more cython extensions. | |||
| ctypedef unsigned char uint8_t | |||
| ctypedef unsigned int uint32_t | |||
There was a problem hiding this comment.
This has also been added in #27334
| @@ -7,18 +7,21 @@ | |||
| # License: BSD 3 clause | |||
|
|
|||
| from libc.math cimport fabs, sqrt, isnan | |||
| from libc.stdint cimport intptr_t | |||
There was a problem hiding this comment.
Do we need this or better use our intp_t instead?
There was a problem hiding this comment.
intp_t aliases npy_intp which aliases Py_intptr_t which aliases intptr_t
I think we better use intp_t for consistency. WDYT?
There was a problem hiding this comment.
I don’t think. I‘m confused and would prefer C/C++ over Cython, but that’s another story.
There was a problem hiding this comment.
Or can someone tell what the difference between inp_t alias Py_ssize_t and intptr_t alias ssize_t is?
There was a problem hiding this comment.
@jjerphan If this point is clear then maybe we can merge this PR?
There was a problem hiding this comment.
Yes, here this choice is safe, but I think we could clarify types for indices in another PR.
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Reference Issues/PRs
Related to #25572.
What does this implement/fix? Explain your changes.
Any other comments?