Skip to content

MAINT cython typedefs in _quad_tree #27351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2023
Merged

MAINT cython typedefs in _quad_tree #27351

merged 1 commit into from
Sep 28, 2023

Conversation

lorentzenchr
Copy link
Member

Reference Issues/PRs

Related to #25572.

What does this implement/fix? Explain your changes.

Any other comments?

@github-actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 111cbc6. Link to the linter CI: here

OmarManzoor
OmarManzoor approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @lorentzenchr

@lorentzenchr lorentzenchr added the Quick Review For PRs that are quick to review label Sep 27, 2023
ogrisel
ogrisel approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well.

@ogrisel ogrisel merged commit 4567245 into scikit-learn:main Sep 28, 2023
lesteve pushed a commit to lesteve/scikit-learn that referenced this pull request Sep 28, 2023
@lorentzenchr @lesteve
MAINT cython typedefs in _quad_tree (scikit-learn#27351)
3ac1be0
@lorentzenchr lorentzenchr deleted the mnt_quad_tree_cython_types branch September 29, 2023 17:04
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@lorentzenchr @REDVM
MAINT cython typedefs in _quad_tree (scikit-learn#27351)
fe5171e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@OmarManzoor OmarManzoor OmarManzoor approved these changes

Assignees
No one assigned
Labels
cython module:neighbors Quick Review For PRs that are quick to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lorentzenchr @ogrisel @OmarManzoor