DOC move some fixes from 1.4 to 1.3.1 #27402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following needs to be moved to 1.4: |
|
Doesn't this (#26760) need to be in 1.4? It's kind of a new feature. |
One could argue it's a fix in the parameter checks that were too strict. No strong opinion though. If we don't consider this a fix we should document it as an enhancement and keep it for 1.4. |
ogrisel
approved these changes
Sep 18, 2023
adrinjalali
approved these changes
Sep 18, 2023
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 18, 2023
|
we got that random error on |
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 19, 2023
|
Yep this is the pickling issue. We should investigate it at some point. Not sure how to reproduce this one. |
jeremiedbb
pushed a commit
that referenced
this pull request
Sep 20, 2023
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While preparing the release 1.3.1, I intend to move some fixes from 1.4 to 1.3.1 when it comes for free, meaning that those changes do not rely on bigger other changes or enhancements implemented in 1.4.
In short I am moving the following:
precisions_cholesky_fromprecisions_init#26416mutual_info_regressionwhenXis of integer dtype #26748PLSRegressionwhen fitted on 1dy#26602