Skip to content

DOC fix deprecation warning in plot_oneclass #27452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 25, 2023
Merged

DOC fix deprecation warning in plot_oneclass #27452

merged 4 commits into from
Sep 25, 2023

Conversation

glemaitre
Copy link
Member

Remove deprecation warning raised by matplotlib in plot_oneclass.py:

WARNING: /Users/glemaitre/Documents/packages/scikit-learn/examples/svm/plot_oneclass.py failed to execute correctly: Traceback (most recent call last):
  File "/Users/glemaitre/Documents/packages/scikit-learn/examples/svm/plot_oneclass.py", line 57, in <module>
    [a.collections[0], b1, b2, c],
  File "/Users/glemaitre/mambaforge/envs/sklearn_dev/lib/python3.10/site-packages/matplotlib/_api/deprecation.py", line 158, in __get__
    emit_warning()
  File "/Users/glemaitre/mambaforge/envs/sklearn_dev/lib/python3.10/site-packages/matplotlib/_api/deprecation.py", line 193, in emit_warning
    warn_deprecated(
  File "/Users/glemaitre/mambaforge/envs/sklearn_dev/lib/python3.10/site-packages/matplotlib/_api/deprecation.py", line 96, in warn_deprecated
    warn_external(warning, category=MatplotlibDeprecationWarning)
  File "/Users/glemaitre/mambaforge/envs/sklearn_dev/lib/python3.10/site-packages/matplotlib/_api/__init__.py", line 381, in warn_external
    warnings.warn(message, category, stacklevel)
matplotlib._api.deprecation.MatplotlibDeprecationWarning: The collections attribute was deprecated in Matplotlib 3.8 and will be removed two minor releases later.

@glemaitre
Copy link
Member Author

ping @ArturoAmorQ

@github-actions
Copy link

github-actions bot commented Sep 22, 2023 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 10bf6da. Link to the linter CI: here

@ArturoAmorQ
Copy link
Member

We seem to have a plotly error that I don't understand.

@glemaitre
Copy link
Member Author

No, it was an error related to the install, most probably a connection issue.

ArturoAmorQ
ArturoAmorQ approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM :)

@glemaitre @ArturoAmorQ
Update examples/svm/plot_oneclass.py
10bf6da 
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
@ArturoAmorQ ArturoAmorQ merged commit 1550432 into scikit-learn:main Sep 25, 2023
lesteve pushed a commit to lesteve/scikit-learn that referenced this pull request Sep 28, 2023
@glemaitre @ArturoAmorQ @lesteve
DOC fix deprecation warning in plot_oneclass (scikit-learn#27452)
33b21c7 
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@glemaitre @ArturoAmorQ @REDVM
DOC fix deprecation warning in plot_oneclass (scikit-learn#27452)
0817dcd 
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArturoAmorQ ArturoAmorQ ArturoAmorQ approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glemaitre @ArturoAmorQ