Skip to content

DOC Early Stopping example overhaul #27466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Dec 7, 2023
Merged

DOC Early Stopping example overhaul #27466

merged 13 commits into from
Dec 7, 2023

Conversation

greyisbetter
Copy link
Contributor

Towards #27025

Initially, my introduction to early stopping was its role in averting overfitting. Therefore, my primary objective for enhancing this example centers on:

  • To prevent overfitting: Early stopping can help to prevent overfitting by stopping the training process before the model has a chance to overfit.
  • To improve training efficiency: By stopping the training process early, early stopping can save you time and computational resources.

cc @lorentzenchr

@github-actions
Copy link

github-actions bot commented Sep 25, 2023 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 7145f3c. Link to the linter CI: here

@greyisbetter
Copy link
Contributor Author

Hi @adrinjalali, I would be grateful if you could also take a look at this.

@adrinjalali
Copy link
Member

One overall comment here is that you can split sections by adding cells (using # %% syntax, and have a description of each cell at the beginning of it.

adrinjalali
adrinjalali reviewed Dec 5, 2023
View reviewed changes
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in the right direction, thanks a lot.

lorentzenchr
lorentzenchr approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this overhaul.
Consider my review as suggestions, not obligatory.

@greyisbetter
Copy link
Contributor Author

Thanks for this overhaul. Consider my review as suggestions, not obligatory.

Two heads are always better than one.

@lorentzenchr
Copy link
Member

@greyisbetter Could you try to fix the lint errors? The CI gives you more information.

lorentzenchr
lorentzenchr reviewed Dec 5, 2023
View reviewed changes
Copy link
Member

@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@greyisbetter Could you also remove the old # Authors:?

Then, I've some suggestion to improve the figure.

@greyisbetter
Copy link
Contributor Author

@lorentzenchr, I want to highlight that the figures created by earlier authors are influenced by the number of estimators and fit time, factors unrelated to overfitting and training error. The alterations in these aspects are a result of my interventions.

adrinjalali
adrinjalali approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

@lorentzenchr lorentzenchr changed the title DOC Early Stopping example improvement DOC Early Stopping example overhaul Dec 7, 2023
@lorentzenchr lorentzenchr merged commit 1dc3549 into scikit-learn:main Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrinjalali adrinjalali adrinjalali approved these changes

@lorentzenchr lorentzenchr lorentzenchr approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@greyisbetter @adrinjalali @lorentzenchr @glemaitre