Skip to content

MAINT cosmetic improvement in _non_trivial_radius test helper #27486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented Sep 28, 2023

Follow-up on a recent refactoring of the pairwise distances reduction tests to address @thomasjpfan's #27281 (comment).

@ogrisel ogrisel added the Quick Review For PRs that are quick to review label Sep 28, 2023
@ogrisel ogrisel added No Changelog Needed module:test-suite everything related to our tests and removed module:metrics labels Sep 28, 2023
@github-actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 4c263bd. Link to the linter CI: here

Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed it in the discussion.

@adrinjalali adrinjalali merged commit 8477d63 into scikit-learn:main Sep 28, 2023
lesteve pushed a commit to lesteve/scikit-learn that referenced this pull request Sep 28, 2023
@ogrisel ogrisel deleted the pairwise-test-helper branch October 24, 2023 15:30
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:test-suite everything related to our tests No Changelog Needed Quick Review For PRs that are quick to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants