DOC Update Pairwise Distances Reductions' documentation #27525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
jjerphan
commented
Oct 4, 2023
lorentzenchr
approved these changes
Oct 5, 2023
See: scikit-learn#20813 Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
thomasjpfan
reviewed
Oct 31, 2023
| # x | | x | ||
| # +-----------⊳ ArgKmin{32,64} RadiusNeighbors{32,64} ⊲-------+ | ||
| # | | ∆ ∆ | | | ||
| # ArgKminClassmode{32,64} | | | | RadiusNeighborsClassMode{32,64} # noqa: E501 |
There was a problem hiding this comment.
ArgKminClassMode is the dispatcher for ArgKminClassmode{32, 64}. I'm not sure where to put that information in the diagram, without getting too confusing.
There was a problem hiding this comment.
I proposed something in a198103.
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
…#27525) Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Part of #25888.
What does this implement/fix? Explain your changes.
Since I do not have as much bandwidth for scikit-learn as before, I am wondering how we can continue to actively maintain a shared understanding and ownership of the Private Distances Reductions' submodule.
There are already a few external resources out, but they are not entirely up to date, and to me it is more appropriate to actually have pieces of knowledge sit next to the actual implementations.
Currently this PR updates to the documentation of the private Pairwise Distances Reductions' sub-module to reflect the latest changes.
What do you think? Do you have any suggestions to help in this regards?
Any other comments?