MAINT Replace double with float64_t inside tree submodule #27539
+289
−285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
|
lmk if you prefer me to do |
ogrisel
approved these changes
Oct 6, 2023
lorentzenchr
approved these changes
Oct 6, 2023
Comment on lines
+214
to
+217
| cdef float64_t left_child_min | ||
| cdef float64_t left_child_max | ||
| cdef float64_t right_child_min | ||
| cdef float64_t right_child_max |
There was a problem hiding this comment.
Good catch! Those were not defined before. I looked into _tree.cpp and obviously Cython figures out to define them as double variables.
double with float64_t inside tree/ submodule
This was referenced Oct 7, 2023
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 31, 2023
…rn#27539) Signed-off-by: Adam Li <adam2392@gmail.com>
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
…rn#27539) Signed-off-by: Adam Li <adam2392@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Follow-up to #27352 (comment)
Related to: #25572
What does this implement/fix? Explain your changes.
Replaces
doublewithfloat64_tinside tree submodule.I can also replace
intwithintp_tin the same PR if desirable.Any other comments?
n/a