Monotonic trees missing values #27630
Draft
+92
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samronsin if you want to easily solve the problem linked to the linter, I encourage you to install Then, It will use the version used by the CI to make the reformat the file before committing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Follow up on #13649 to allow monotonic constraints on tree-based models when missing values are present (introduced in #23595 and #26391).
What does this implement/fix? Explain your changes.
Update on tests and monotonic constraints checks to make them work with missing values.
Any other comments?
For trees built with missing values, I had to work around:
assert_nd_reg_tree_children_monotonic_bounded.Current implementation works, but I'm not satisfied with having to deal with middle values outside of the bounds. Will investigate further.