FIX don't modify X in-place when precomputed in DBSCAN #27651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
reviewed
Oct 30, 2023
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre
reviewed
Nov 14, 2023
| # the sparse matrix. If `X` is modified in-place, the zeros from | ||
| # the diagonal will be made explicit. | ||
| np.fill_diagonal(X, 0) | ||
| X = csr_container(X) |
There was a problem hiding this comment.
We could make an assert just below this line to be sure that we have implicit zeros.
glemaitre
approved these changes
Nov 14, 2023
glemaitre
approved these changes
Nov 14, 2023
…rn into dbscan_matrix_copy
glemaitre
approved these changes
Nov 16, 2023
OmarManzoor
approved these changes
Dec 1, 2023
|
@tataganesh Could you kindly resolve the conflict? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
See also #27508
What does this implement/fix? Explain your changes.
DBSCAN modifies the precomputed sparse matrix passed to the fit method, which can lead to undesirable behaviour. This PR creates a copy of the sparse matrix before it is modified.