MNT Unpin Sphinx and pandas in doc build #27656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The doc build completed without error. I looked at the generated doc vs the dev doc (the landing page, a few examples, a few user guide pages) and I didn't spot any obvious difference. Search seems to work fine (this was why we pinned sphinx to 6.0 before): https://output.circle-artifacts.com/output/job/b88f0bab-bb68-4b74-aafc-4a6a674d8c9b/artifacts/0/doc/search.html?q=linear There are no FutureWarning due to pandas and seaborn e.g. in this example |
|
Let's see what happens |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 31, 2023
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the sphinx 6 pin is not necessary any more and the search seems to work locally with the latest sphinx release. Context for this #25504.
Also avoids confusing contributors like #27643.
The pandas pin was done in #27448 to avoid a warning. It should be fixed in seaborn 0.13 released September 29.