Skip to content

DOC update the sponsors list on landing and about pages #27660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 27, 2023

Conversation

GaelVaroquaux
Copy link
Member

Remove actors that were sponsors before but have no longer been active for a while.

Should we add nvidia, because of @betatim (and actually on our side, we might have good things to announce)?

@github-actions
Copy link

github-actions bot commented Oct 25, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 49a56b8. Link to the linter CI: here

@glemaitre glemaitre added the To backport PR merged in master that need a backport to a release branch defined based on the milestone. label Oct 25, 2023
@glemaitre
Copy link
Member

I added the tag "to backport" such that it is available in stable page by cherry-picking the commit in the 1.3.X branch.

@glemaitre
Copy link
Member

@GaelVaroquaux In the about page, we tend to acknowledge the past sponsors. I am wondering if we should not have a section of the past sponsor of the consortium and still keep the logo there.

@lucyleeow @thomasjpfan @Micky774 @adrinjalali Shall we update the Quansight Lab and HuggingFace

Regarding the rendering, I see an issue with a (probably) an issue with a <div> showing a darker section under the logo:

image

It could be nice to fix it.

@glemaitre
Copy link
Member

I think that we are missing the HuggingFace logo for the consortium in the about page.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to keep this one for @amueller sponsoring section. I assume this is one of the reason the CI fail.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the about page, we tend to acknowledge the past sponsors

Good point. I'll do this

Also, I really think that we should add Nvidia. @betatim : do you confirm?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@betatim
Copy link
Member

betatim commented Oct 25, 2023

One thing that has been on my todo list, but never quite reached the top is adding a "NVIDIA funds Tim Head since 2022" with a logo to https://scikit-learn.org/stable/about.html#funding - should I make a new PR for that or do you want to do that here?

I think we can also add the NVIDIA logo to the list of consortium sponsors. As far as I can tell everyone who needs to say "yes" has done so. We should also publish the blog post?!

@GaelVaroquaux
Copy link
Member Author

OK, I had done quite a sloppy job (that's what I get for doing PRs during conference calls).

I forced pushed something that should be better, that does add nvidia, and updates the about correctly.

Let's see how it renders.

@GaelVaroquaux GaelVaroquaux changed the title DOC: remove past sponsors [MRG] DOC: remove past sponsors Oct 25, 2023
@GaelVaroquaux
Copy link
Member Author

OK, this PR now renders well, and I think that it is ready to review and merge.

@lucyleeow
Copy link
Member

@lucyleeow @thomasjpfan @Micky774 @adrinjalali Shall we update the Quansight Lab and HuggingFace

+1

@adrinjalali
Copy link
Member

+1 on removing Hugging Face on my side.

@GaelVaroquaux
Copy link
Member Author

GaelVaroquaux commented Oct 26, 2023 via email

@GaelVaroquaux
Copy link
Member Author

GaelVaroquaux commented Oct 26, 2023 via email

Copy link
Member

@betatim betatim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side

@glemaitre
Copy link
Member

As in mentioning Qansight Lab for @lucyleeow and @Micky774 at the present tense, and for @thomasjpfan at the past tense?

Let's go ahead with such formulation.

@glemaitre glemaitre changed the title [MRG] DOC: remove past sponsors DOC update the sponsors list on landing and about pages Oct 26, 2023
@betatim
Copy link
Member

betatim commented Oct 27, 2023

I'll merge this so it is done/doesn't get lost over the weekend. We can keep tweaking in a new PR

Thanks for the house keeping!

@betatim betatim merged commit b435c5e into scikit-learn:main Oct 27, 2023
@GaelVaroquaux
Copy link
Member Author

Thanks @betatim !

@thomasjpfan
Copy link
Member

and for @thomasjpfan at the past tense?

This works for me. Thank you for updating the page.

RUrlus pushed a commit to RUrlus/scikit-learn that referenced this pull request Oct 30, 2023
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation No Changelog Needed To backport PR merged in master that need a backport to a release branch defined based on the milestone.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants