-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
DOC update the sponsors list on landing and about pages #27660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I added the tag "to backport" such that it is available in |
@GaelVaroquaux In the about page, we tend to acknowledge the past sponsors. I am wondering if we should not have a section of the past sponsor of the consortium and still keep the logo there. @lucyleeow @thomasjpfan @Micky774 @adrinjalali Shall we update the Quansight Lab and HuggingFace Regarding the rendering, I see an issue with a (probably) an issue with a ![]() It could be nice to fix it. |
I think that we are missing the HuggingFace logo for the consortium in the about page. |
doc/images/microsoft.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to keep this one for @amueller sponsoring section. I assume this is one of the reason the CI fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the about page, we tend to acknowledge the past sponsors
Good point. I'll do this
Also, I really think that we should add Nvidia. @betatim : do you confirm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
One thing that has been on my todo list, but never quite reached the top is adding a "NVIDIA funds Tim Head since 2022" with a logo to https://scikit-learn.org/stable/about.html#funding - should I make a new PR for that or do you want to do that here? I think we can also add the NVIDIA logo to the list of consortium sponsors. As far as I can tell everyone who needs to say "yes" has done so. We should also publish the blog post?! |
5f0f558
to
93ea4f8
Compare
OK, I had done quite a sloppy job (that's what I get for doing PRs during conference calls). I forced pushed something that should be better, that does add nvidia, and updates the about correctly. Let's see how it renders. |
OK, this PR now renders well, and I think that it is ready to review and merge. |
+1 |
+1 on removing Hugging Face on my side. |
+1 on removing Hugging Face on my side.
They are partner of the Inria foundation.
I put your employed at the past on the about page
|
As in mentioning Qansight Lab for @lucyleeow and @Micky774 at the present tense, and for @thomasjpfan at the past tense?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side
Let's go ahead with such formulation. |
I'll merge this so it is done/doesn't get lost over the weekend. We can keep tweaking in a new PR Thanks for the house keeping! |
Thanks @betatim ! |
This works for me. Thank you for updating the page. |
Remove actors that were sponsors before but have no longer been active for a while.
Should we add nvidia, because of @betatim (and actually on our side, we might have good things to announce)?