Array API cupy fixes #27672
Closed
Array API cupy fixes #27672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was expecting to see a modification to But I agree (now that you say it) that |
|
Even more confusingly, if I use import cupy as cp
from sklearn import set_config
from sklearn.model_selection import train_test_split
set_config(array_api_dispatch=True)
X = cp.random.random_sample((42, 4), dtype=cp.float32)
train_test_split(X) |
|
Fixed in #28407. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a few problems when running the existing Array API tests on a machine with CUDA and cupy.
There are a few easy fixes but there is also a problem with
train_test_splitthat I did not solve yet.I don't understand why the existing tests pass with the strict
numpy.array_api: we should not be able to fancy index an Array usingarray[indices, ...]but instead we should usearray.take(indices, axis=0). This needs more investigation but I decided to open an early draft PR to share the existence of the problem with @betatim and others.