Skip to content

Conversation

glemaitre
Copy link
Member

Spotted while working on #27700

_get_response_values does not accept predict_log_proba. The procedure is exactly the same as predict_proba because the shape of the array is the same.

I parametrized the tests to test whenever it was possible.

@glemaitre
Copy link
Member Author

ping @lucyleeow I think that you will be able to review this one ;)

Copy link

github-actions bot commented Nov 3, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: f2ce5e6. Link to the linter CI: here

Copy link
Member

@lucyleeow lucyleeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

Copy link
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @glemaitre

@OmarManzoor OmarManzoor merged commit 0027893 into scikit-learn:main Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants