@glemaitre Yes I can confirm that this fixes my issue.

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

_{Generated for commit: 199e360. Link to the linter CI: here}

Not sure that there is a (not too complex) way to test for this. You'd probably have to patch the method used to determine the platform's default encoding in open()

I pushed a commit with a test. I am guessing the test will run on Posix platforms and be skipped on Windows. I could not find a simpler way to do it, if deemed to complex this can always be reverted 😉.

Better to have a test. Thanks @lesteve

Nice! I like it. And with C as locale reading the file fails for me, so this looks like a good enough test.

Oh well the CI error comes from the fact that the locale resetting logic does not work on some platforms. This is probably due to python/cpython#78115 (comment) but this needs more investigation.

I tweaked the test in my last commit, the debian 32bit build is now green.

codecov is red because we don't have coverage for Windows since #26052 it seems (and I expect locale.setlocale(locale.LC_CTYPE, "C") to raise a locale.Error on Windows but I have no easy way to double-check)

Edit: actually I double-checked and the "C" locale was available on the Windows VM I managed to create. It might be always available if I interpret this correctly

A value of "C" for locale specifies the minimal environment for C translation

In any case, I feel the try/except in the test does not hurt ...

Let's merge this!